-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed KdocComments
and KdocFormatting
#1892
base: master
Are you sure you want to change the base?
Conversation
…es in class KDoc at the same time
…aven't empty line before them - added smoke test for class kdoc
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1892 +/- ##
============================================
+ Coverage 77.95% 77.99% +0.04%
+ Complexity 2996 2976 -20
============================================
Files 134 134
Lines 8863 8848 -15
Branches 2119 2112 -7
============================================
- Hits 6909 6901 -8
+ Misses 943 941 -2
+ Partials 1011 1006 -5 ☔ View full report in Codecov by Sentry. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 167 files ±0 167 suites ±0 8m 6s ⏱️ -19s Results for commit ffd6dd2. ± Comparison against base commit cd77a0b. ♻️ This comment has been updated with latest results. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 167 files ±0 167 suites ±0 3m 28s ⏱️ +3s Results for commit ffd6dd2. ± Comparison against base commit cd77a0b. ♻️ This comment has been updated with latest results. |
...t-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt
Show resolved
Hide resolved
...t-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand how 90% of refactoring work, but basically there are a lot of tests, so I believe in you :)
diktat-cli/src/test/resources/test/smoke/src/main/kotlin/ClassKdocExpected.kt
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph2/kdoc/ConstructorCommentPropertiesTest.kt
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph2/kdoc/ConstructorCommentKDocExpected.kt
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph2/kdoc/ConstructorCommentNoKDocTest.kt
Show resolved
Hide resolved
…ugfix/kdoc_formatting # Conflicts: # diktat-cli/src/test/kotlin/com/saveourtool/diktat/smoke/DiktatSmokeTestBase.kt
What's done:
KdocComments
.KdocFormatting
for case when@property
and@constructor
basic tags haven't empty line before them.@property
tag.Closes #1884