Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script for Windows #1859

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Added script for Windows #1859

merged 4 commits into from
Dec 13, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Dec 12, 2023

What's done:

  • renamed unix script to header
  • added script for Windows
  • updated workflow to add Windows script as artifact
  • fixed coloring in plain reporter

### What's done:
- renamed unix script to header
- added script for Windows
- updated workflow to add Windows script as artifact
### What's done:
- renamed unix script to header
- added script for Windows
- updated workflow to add Windows script as artifact
@nulls nulls self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (73cd9a7) 78.39% compared to head (e8ff9f6) 78.42%.

Files Patch % Lines
...ourtool/diktat/ktlint/DiktatReporterFactoryImpl.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1859      +/-   ##
============================================
+ Coverage     78.39%   78.42%   +0.03%     
  Complexity     2456     2456              
============================================
  Files           133      133              
  Lines          8645     8641       -4     
  Branches       2184     2185       +1     
============================================
  Hits           6777     6777              
+ Misses          898      894       -4     
  Partials        970      970              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 17s ⏱️ -27s
1 414 tests ±0  1 378 ✔️ ±0  36 💤 ±0  0 ±0 
2 793 runs  ±0  2 757 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit e8ff9f6. ± Comparison against base commit 73cd9a7.

Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 56s ⏱️ -4s
1 414 tests ±0  1 397 ✔️ ±0  17 💤 ±0  0 ±0 
2 793 runs  ±0  2 776 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit e8ff9f6. ± Comparison against base commit 73cd9a7.

@nulls nulls enabled auto-merge (squash) December 12, 2023 13:19
@nulls nulls added this to the 2.0.0 milestone Dec 12, 2023
@nulls nulls merged commit c20f2d5 into master Dec 13, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/windows-cli branch December 13, 2023 09:54
@0x6675636b796f75676974687562
Copy link
Member

As was recently discovered, there may be two instances of bash.exe on a typical workstation:

  • The one from MSys Git, typically %ProgramFiles%\Git\usr\bin\bash.exe
  • The one from WSL (if WSL is installed): %windir%\system32\bash.exe. This one starts the default WSL distribution if one isn't running, and has wslhost.exe as the child process:

image

We can use one or the other.

@nulls
Copy link
Member Author

nulls commented Dec 13, 2023

As was recently discovered, there may be two instances of bash.exe on a typical workstation:

  • The one from MSys Git, typically %ProgramFiles%\Git\usr\bin\bash.exe
  • The one from WSL (if WSL is installed): %windir%\system32\bash.exe. This one starts the default WSL distribution if one isn't running, and has wslhost.exe as the child process:

image

We can use one or the other.

I think The one from MSys Git, typically %ProgramFiles%\Git\usr\bin\bash.exe is better (current behavior), since it runs Java on Windows instead of WSL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants