CUSTOM_GETTERS_SETTERS false positive when a property has a backing field
#1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * fix
1 task
kgevorkyan
reviewed
Nov 22, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt
Outdated
Show resolved
Hide resolved
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 6m 33s ⏱️ -55s Results for commit d4d8fea. ± Comparison against base commit b5c1a37. ♻️ This comment has been updated with latest results. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 9m 20s ⏱️ +20s Results for commit d4d8fea. ± Comparison against base commit b5c1a37. ♻️ This comment has been updated with latest results. |
orchestr7
reviewed
Nov 23, 2023
...ules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter6/CustomGetterSetterRule.kt
Show resolved
Hide resolved
orchestr7
reviewed
Nov 23, 2023
...ules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter6/CustomGetterSetterRule.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Nov 23, 2023
...ules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter6/CustomGetterSetterRule.kt
Outdated
Show resolved
Hide resolved
…ield. - added `ASTNode.isPrivate()`, `ASTNode.hasSetterGetter()` methods - added `isPairPropertyBackingField(propertyNode: ASTNode?, backingFieldNode: ASTNode?)` function - added warning tests. Closes #1709
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1815 +/- ##
============================================
+ Coverage 78.62% 78.64% +0.02%
+ Complexity 2441 2432 -9
============================================
Files 126 126
Lines 8555 8562 +7
Branches 2163 2171 +8
============================================
+ Hits 6726 6734 +8
- Misses 861 862 +1
+ Partials 968 966 -2 ☔ View full report in Codecov by Sentry. |
kgevorkyan
approved these changes
Nov 24, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt
Outdated
Show resolved
Hide resolved
DrAlexD
reviewed
Nov 24, 2023
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
CUSTOM_GETTERS_SETTERSon properties with backing field.Closes #1709