Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced diktat-runner #1813

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Introduced diktat-runner #1813

merged 5 commits into from
Nov 22, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 21, 2023

What's done:

  • added diktat-runner
  • migrated diktat-cli, diktat-maven-plugin and diktat-gradle-plugin to diktat-runner

It closes #1796

### What's done:
- added `diktat-runner`
- migrated `diktat-cli`, `diktat-maven-plugin` and `diktat-gradle-plugin` to `diktat-runner`

It closes #1796
@nulls nulls self-assigned this Nov 21, 2023
@nulls nulls marked this pull request as ready for review November 21, 2023 14:43
Copy link
Contributor

github-actions bot commented Nov 21, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   8m 39s ⏱️ + 2m 55s
1 393 tests ±0  1 357 ✔️ ±0  36 💤 ±0  0 ±0 
2 772 runs  ±0  2 736 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 5789bec. ± Comparison against base commit 26bc29d.

♻️ This comment has been updated with latest results.

@nulls nulls enabled auto-merge (squash) November 21, 2023 14:48
Copy link
Contributor

github-actions bot commented Nov 21, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 56s ⏱️ -2s
1 393 tests ±0  1 376 ✔️ ±0  17 💤 ±0  0 ±0 
2 772 runs  ±0  2 755 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit 5789bec. ± Comparison against base commit 26bc29d.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (26bc29d) 78.39% compared to head (5789bec) 78.77%.

Files Patch % Lines
...rtool/diktat/plugin/gradle/tasks/DiktatTaskBase.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1813      +/-   ##
============================================
+ Coverage     78.39%   78.77%   +0.37%     
+ Complexity     2432     2430       -2     
============================================
  Files           128      126       -2     
  Lines          8578     8526      -52     
  Branches       2151     2150       -1     
============================================
- Hits           6725     6716       -9     
+ Misses          893      850      -43     
  Partials        960      960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nulls nulls merged commit 51195ee into master Nov 22, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/runner#1796 branch November 22, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a wrapper to run diktat for spotless
2 participants