Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceTask in Gradle plugin #1797

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

SourceTask in Gradle plugin #1797

wants to merge 5 commits into from

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 14, 2023

What's done:

  • migrated to SourceTask
  • removed inputs

It closes #1026

### What's done:
- migrated to SourceTask
- removed inputs

It closes #1026
@nulls nulls self-assigned this Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

2 files   -    163  2 suites   - 163   7s ⏱️ - 5m 34s
5 tests  - 1 390  5 ✔️  - 1 354  0 💤  - 36  0 ±0 
5 runs   - 2 769  5 ✔️  - 2 733  0 💤  - 36  0 ±0 

Results for commit 2f37366. ± Comparison against base commit 7b7d2b6.

This pull request removes 1390 tests.
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in githubActions mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with excludes()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with non-existent inputs()
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 files   -    163  2 suites   - 163   15s ⏱️ - 12m 51s
5 tests  - 1 390  5 ✔️  - 1 373  0 💤  - 17  0 ±0 
5 runs   - 2 769  5 ✔️  - 2 752  0 💤  - 17  0 ±0 

Results for commit 2f37366. ± Comparison against base commit 7b7d2b6.

This pull request removes 1390 tests.
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in githubActions mode()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with excludes()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line with non-existent inputs()
…

♻️ This comment has been updated with latest results.

@nulls
Copy link
Member Author

nulls commented Nov 15, 2023

The comment from the original is about returning back files to have a common configuration with detekt to have a common configuration for such projects.

Spotless uses FileCollection as input and it does support ant patterns, but doesn't support exclusion uses a specific methods to support ant patterns.
Need to try to use both of them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diktat-gradle-plugin shouldn't be using files for patterns
1 participant