Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warning FUNCTION_BOOLEAN_PREFIX on operator fun #1767

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

diphtongue
Copy link
Contributor

What's done:

  • fixed warning FUNCTION_BOOLEAN_PREFIX on operator fun.
  • added warning test.

Closes #1723

### What's done:
- fixed warning `FUNCTION_BOOLEAN_PREFIX` on `operator fun`.
- added warning test.

Closes #1723
@diphtongue diphtongue self-assigned this Oct 27, 2023
@diphtongue diphtongue added the bug Something isn't working label Oct 27, 2023
@diphtongue diphtongue requested review from nulls and DrAlexD October 27, 2023 13:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   10m 35s ⏱️ + 6m 46s
1 388 tests +1  1 345 ✔️ +1  43 💤 ±0  0 ±0 
2 767 runs  +1  2 724 ✔️ +1  43 💤 ±0  0 ±0 

Results for commit 6fa6ade. ± Comparison against base commit c28f1a1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   8m 19s ⏱️ + 2m 29s
1 388 tests +1  1 357 ✔️ +1  31 💤 ±0  0 ±0 
2 767 runs  +1  2 736 ✔️ +1  31 💤 ±0  0 ±0 

Results for commit 6fa6ade. ± Comparison against base commit c28f1a1.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1767 (6fa6ade) into master (c28f1a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1767   +/-   ##
=========================================
  Coverage     78.25%   78.25%           
+ Complexity     2410     2409    -1     
=========================================
  Files           126      126           
  Lines          8451     8453    +2     
  Branches       2148     2149    +1     
=========================================
+ Hits           6613     6615    +2     
  Misses          880      880           
  Partials        958      958           
Files Coverage Δ
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 82.72% <100.00%> (-0.16%) ⬇️
...m/saveourtool/diktat/ruleset/utils/AstNodeUtils.kt 80.62% <100.00%> (+0.20%) ⬆️

@diphtongue diphtongue enabled auto-merge (squash) October 31, 2023 14:59
@diphtongue diphtongue merged commit 9423c75 into master Nov 1, 2023
32 checks passed
@diphtongue diphtongue deleted the bugfix/fix-operator-fun branch November 1, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FUNCTION_BOOLEAN_PREFIX on operator fun
5 participants