Updating the package name to the new one #1687

orchestr7 · 2023-06-07T14:21:19Z

What's done:

package name is now com.saveourtool (same as for organization)
removed diktat plugin usage in our project (until the release to central)

### What's done: - package name is now com.saveourtool (same as for organization) - removed diktat plugin usage in our project (until the release to central)

github-actions · 2023-06-07T14:33:27Z

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

  162 files ±0   162 suites ±0 10m 17s ⏱️ + 4m 37s
1 371 tests ±0 1 335 ✔️ ±0 36 💤 ±0 0 ❌ ±0
2 750 runs ±0 2 714 ✔️ ±0 36 💤 ±0 0 ❌ ±0

Results for commit 6beb4c1. ± Comparison against base commit 1598f09.

This pull request removes 1371 and adds 1371 tests. Note that renamed tests count towards both.

org.cqfn.diktat.ktlint.KtLintRuleWrapperTest ‑ KtLint keeps order with RuleVisitorModifierRunAfterRule()
org.cqfn.diktat.ktlint.KtLintRuleWrapperTest ‑ check KtLintRuleSetWrapper with duplicate()
org.cqfn.diktat.ktlint.KtLintRuleWrapperTest ‑ check OrderedRule()
org.cqfn.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
org.cqfn.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value()
org.cqfn.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
…

com.saveourtool.diktat.ktlint.KtLintRuleWrapperTest ‑ KtLint keeps order with RuleVisitorModifierRunAfterRule()
com.saveourtool.diktat.ktlint.KtLintRuleWrapperTest ‑ check KtLintRuleSetWrapper with duplicate()
com.saveourtool.diktat.ktlint.KtLintRuleWrapperTest ‑ check OrderedRule()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
…

This pull request removes 36 skipped tests and adds 36 skipped tests. Note that renamed tests count towards both.

org.cqfn.diktat.plugin.maven.DiktatBaseMojoTest ‑ test default plugin configuration
org.cqfn.diktat.plugin.maven.DiktatBaseMojoTest ‑ test plugin custom configuration
org.cqfn.diktat.ruleset.chapter3.FileStructureRuleTest ‑ check by #4 should trigger()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used in several scopes()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used only in nested scope()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside collection methods()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside of loops()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ should check variables initialized with constructor with no parameters()
org.cqfn.diktat.ruleset.chapter3.files.NewlinesRuleWarnTest ‑ long argument list should be split into several lines()
org.cqfn.diktat.ruleset.chapter4.SmartCastRuleWarnTest ‑ smart cast in when bad()
…

com.saveourtool.diktat.plugin.maven.DiktatBaseMojoTest ‑ test default plugin configuration
com.saveourtool.diktat.plugin.maven.DiktatBaseMojoTest ‑ test plugin custom configuration
com.saveourtool.diktat.ruleset.chapter3.FileStructureRuleTest ‑ check by #4 should trigger()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used in several scopes()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used only in nested scope()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside collection methods()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside of loops()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ should check variables initialized with constructor with no parameters()
com.saveourtool.diktat.ruleset.chapter3.files.NewlinesRuleWarnTest ‑ long argument list should be split into several lines()
com.saveourtool.diktat.ruleset.chapter4.SmartCastRuleWarnTest ‑ smart cast in when bad()
…

♻️ This comment has been updated with latest results.

github-actions · 2023-06-07T14:35:56Z

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

  162 files ±0   162 suites ±0 10m 14s ⏱️ - 1m 3s
1 371 tests ±0 1 354 ✔️ ±0 17 💤 ±0 0 ❌ ±0
2 750 runs ±0 2 733 ✔️ ±0 17 💤 ±0 0 ❌ ±0

Results for commit 1651946. ± Comparison against base commit 1598f09.

This pull request removes 1371 and adds 1371 tests. Note that renamed tests count towards both.

org.cqfn.diktat.ktlint.KtLintRuleWrapperTest ‑ KtLint keeps order with RuleVisitorModifierRunAfterRule()
org.cqfn.diktat.ktlint.KtLintRuleWrapperTest ‑ check KtLintRuleSetWrapper with duplicate()
org.cqfn.diktat.ktlint.KtLintRuleWrapperTest ‑ check OrderedRule()
org.cqfn.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
org.cqfn.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value()
org.cqfn.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
org.cqfn.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
…

com.saveourtool.diktat.ktlint.KtLintRuleWrapperTest ‑ KtLint keeps order with RuleVisitorModifierRunAfterRule()
com.saveourtool.diktat.ktlint.KtLintRuleWrapperTest ‑ check KtLintRuleSetWrapper with duplicate()
com.saveourtool.diktat.ktlint.KtLintRuleWrapperTest ‑ check OrderedRule()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default extension properties()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check default reporter type value()
com.saveourtool.diktat.plugin.gradle.DiktatGradlePluginTest ‑ check that tasks are registered()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line for various inputs()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type and output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line has reporter type without output()
com.saveourtool.diktat.plugin.gradle.DiktatJavaExecTaskTest ‑ check command line in debug mode()
…

This pull request removes 17 skipped tests and adds 17 skipped tests. Note that renamed tests count towards both.

org.cqfn.diktat.plugin.maven.DiktatBaseMojoTest ‑ test default plugin configuration
org.cqfn.diktat.plugin.maven.DiktatBaseMojoTest ‑ test plugin custom configuration
org.cqfn.diktat.ruleset.chapter3.FileStructureRuleTest ‑ check by #4 should trigger()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used in several scopes()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used only in nested scope()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside collection methods()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside of loops()
org.cqfn.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ should check variables initialized with constructor with no parameters()
org.cqfn.diktat.ruleset.chapter3.files.NewlinesRuleWarnTest ‑ long argument list should be split into several lines()
org.cqfn.diktat.ruleset.chapter4.SmartCastRuleWarnTest ‑ smart cast in when bad()
…

com.saveourtool.diktat.plugin.maven.DiktatBaseMojoTest ‑ test default plugin configuration
com.saveourtool.diktat.plugin.maven.DiktatBaseMojoTest ‑ test plugin custom configuration
com.saveourtool.diktat.ruleset.chapter3.FileStructureRuleTest ‑ check by #4 should trigger()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used in several scopes()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ local variables defined in outer scope and used only in nested scope()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside collection methods()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ need to allow declaring vars outside of loops()
com.saveourtool.diktat.ruleset.chapter3.LocalVariablesWarnTest ‑ should check variables initialized with constructor with no parameters()
com.saveourtool.diktat.ruleset.chapter3.files.NewlinesRuleWarnTest ‑ long argument list should be split into several lines()
com.saveourtool.diktat.ruleset.chapter4.SmartCastRuleWarnTest ‑ smart cast in when bad()
…

♻️ This comment has been updated with latest results.

codecov · 2023-06-07T17:35:16Z

Codecov Report

Merging #1687 (a1494fd) into master (1598f09) will not change coverage.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master    #1687   +/-   ##
=========================================
  Coverage     78.72%   78.72%           
  Complexity     2317     2317           
=========================================
  Files           124      124           
  Lines          8151     8151           
  Branches       2062     2062           
=========================================
  Hits           6417     6417           
  Misses          826      826           
  Partials        908      908

Impacted Files	Coverage Δ
...c/main/kotlin/com/saveourtool/diktat/DiktatMain.kt	`0.00% <ø> (ø)`
...in/kotlin/com/saveourtool/diktat/cli/DiktatMode.kt	`0.00% <ø> (ø)`
...lin/com/saveourtool/diktat/cli/DiktatProperties.kt	`0.00% <0.00%> (ø)`
...ain/kotlin/com/saveourtool/diktat/util/CliUtils.kt	`77.27% <ø> (ø)`
...n/com/saveourtool/diktat/common/cli/CliArgument.kt	`0.00% <ø> (ø)`
...ktat/common/config/reader/ApplicationProperties.kt	`0.00% <ø> (ø)`
...t/common/config/reader/JsonResourceConfigReader.kt	`41.66% <ø> (ø)`
...ol/diktat/common/config/rules/RulesConfigReader.kt	`39.28% <ø> (ø)`
...aveourtool/diktat/plugin/gradle/DiktatExtension.kt	`100.00% <ø> (ø)`
...ourtool/diktat/plugin/gradle/DiktatGradlePlugin.kt	`100.00% <ø> (ø)`
... and 113 more

... and 2 files with indirect coverage changes

.github/workflows/diktat.yml

README.md

diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/constants/Warnings.kt

...rules/src/main/kotlin/com/saveourtool/diktat/ruleset/rules/chapter3/files/IndentationRule.kt

diktat-rules/src/test/kotlin/com/saveourtool/diktat/ruleset/chapter2/KdocFormattingTest.kt

...test-framework/src/main/java/com/saveourtool/diktat/test/framework/common/StreamGobbler.java

gradle/libs.versions.toml

gradle/plugins/build.gradle.kts

...lugins/src/main/kotlin/org/cqfn/diktat/buildutils/diktat-convention-configuration.gradle.kts

Updating the package name to the new one

7aa6869

### What's done: - package name is now com.saveourtool (same as for organization) - removed diktat plugin usage in our project (until the release to central)

orchestr7 added 2 commits June 7, 2023 19:42

More changes with renaming + stabilization of tests

9f966e7

More changes with renaming + stabilization of tests

a20f6b2

orchestr7 closed this Jun 7, 2023

orchestr7 reopened this Jun 7, 2023

More changes with renaming + stabilization of tests

45e91ba

orchestr7 closed this Jun 7, 2023

orchestr7 reopened this Jun 7, 2023

orchestr7 closed this Jun 8, 2023

orchestr7 reopened this Jun 8, 2023

nulls requested changes Jun 8, 2023

View reviewed changes

orchestr7 marked this pull request as draft June 8, 2023 09:44

orchestr7 force-pushed the feature/updating_name branch 2 times, most recently from a2370c4 to 6f91540 Compare June 9, 2023 10:19

Github action for snapshot diktat

5958619

orchestr7 force-pushed the feature/updating_name branch 2 times, most recently from f4ae8bf to acb8ab9 Compare June 9, 2023 14:36

orchestr7 mentioned this pull request Jun 9, 2023

Investigate false negative issues in diktat's code #1691

Open

orchestr7 force-pushed the feature/updating_name branch 2 times, most recently from 1f101c0 to 16b2c5d Compare June 9, 2023 14:57

nulls approved these changes Jun 9, 2023

View reviewed changes

Github action for snapshot diktat

94d7139

orchestr7 force-pushed the feature/updating_name branch from 16b2c5d to 94d7139 Compare June 9, 2023 15:04

Merge branch 'master' into feature/updating_name

8e3b755

orchestr7 force-pushed the feature/updating_name branch 3 times, most recently from 2645527 to ff3decc Compare June 9, 2023 16:04

Github action for snapshot diktat

6beb4c1

orchestr7 force-pushed the feature/updating_name branch from ff3decc to 6beb4c1 Compare June 9, 2023 16:12

Github action for snapshot diktat

a1494fd

orchestr7 marked this pull request as ready for review June 9, 2023 16:36

orchestr7 enabled auto-merge (squash) June 9, 2023 16:38

orchestr7 merged commit d7d39f0 into master Jun 9, 2023

orchestr7 deleted the feature/updating_name branch June 9, 2023 16:38

nulls linked an issue Jun 13, 2023 that may be closed by this pull request

Relocate to new package #1642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating the package name to the new one #1687

Updating the package name to the new one #1687

orchestr7 commented Jun 7, 2023

github-actions bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023 •

edited

Loading

codecov bot commented Jun 7, 2023 •

edited

Loading

Updating the package name to the new one #1687

Updating the package name to the new one #1687

Conversation

orchestr7 commented Jun 7, 2023

What's done:

github-actions bot commented Jun 7, 2023 • edited Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

github-actions bot commented Jun 7, 2023 • edited Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

codecov bot commented Jun 7, 2023 • edited Loading

Codecov Report

github-actions bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023 •

edited

Loading

codecov bot commented Jun 7, 2023 •

edited

Loading