CUSTOM_GETTERS_SETTERS false positive on the override of fields #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * added check for override getter Closes #1504
Cheshiriks
requested review from
0x6675636b796f75676974687562,
kgevorkyan and
nulls
kgevorkyan
approved these changes
Feb 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #1606 +/- ##
=========================================
Coverage 82.44% 82.44%
- Complexity 2328 2330 +2
=========================================
Files 112 112
Lines 7854 7856 +2
Branches 2038 2040 +2
=========================================
+ Hits 6475 6477 +2
Misses 453 453
Partials 926 926
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 37m 0s ⏱️ + 4m 53s For more details on these failures, see this check. Results for commit ee880c8. ± Comparison against base commit 98cdfaa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes #1504