Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diktat:fix #1585

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Fix diktat:fix #1585

merged 2 commits into from
Dec 13, 2022

Conversation

nulls
Copy link
Member

@nulls nulls commented Dec 6, 2022

What's done:

  • moved configuration for diktat-maven-plugin to pluginManagements. It forces diktat:fix to use this configuration when diktat:fix called manually

nulls added 2 commits December 6, 2022 12:18
### What's done:
* moved configuration for diktat-maven-plugin to pluginManagements. It forces `diktat:fix` to use this configuration when `diktat:fix` called manually
@nulls nulls enabled auto-merge (squash) December 6, 2022 09:20
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1585 (1d5a469) into master (0848736) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1585   +/-   ##
=========================================
  Coverage     82.43%   82.43%           
  Complexity     2323     2323           
=========================================
  Files           112      112           
  Lines          7845     7845           
  Branches       2034     2034           
=========================================
  Hits           6467     6467           
  Misses          453      453           
  Partials        925      925           
Flag Coverage Δ
unittests 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   165 files     165 suites   25m 56s ⏱️
2 007 tests 1 990 ✔️ 15 💤 2
2 009 runs  1 992 ✔️ 15 💤 2

For more details on these failures, see this check.

Results for commit 1d5a469.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files     164 suites   33m 7s ⏱️
1 988 tests 1 969 ✔️ 15 💤 4
1 992 runs  1 973 ✔️ 15 💤 4

For more details on these failures, see this check.

Results for commit 1d5a469.

@orchestr7 orchestr7 requested a review from petertrr December 13, 2022 02:43
@nulls nulls merged commit c2886a9 into master Dec 13, 2022
@nulls nulls deleted the feature/fix-diktat-fix branch December 13, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants