Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for UNUSED_IMPORT in KDoc #1368

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Fix for UNUSED_IMPORT in KDoc #1368

merged 4 commits into from
Jun 16, 2022

Conversation

nulls
Copy link
Member

@nulls nulls commented Jun 16, 2022

What's done:

  • supported KDOC_MARKDOWN_LINK as references

This pull request closes #1326

@nulls nulls self-assigned this Jun 16, 2022
@nulls nulls added this to the 1.1.2 milestone Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1368 (eb4902c) into master (bf8f624) will increase coverage by 0.02%.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##             master    #1368      +/-   ##
============================================
+ Coverage     83.53%   83.55%   +0.02%     
- Complexity     2579     2581       +2     
============================================
  Files           106      106              
  Lines          7523     7529       +6     
  Branches       2083     2084       +1     
============================================
+ Hits           6284     6291       +7     
  Misses          358      358              
+ Partials        881      880       -1     
Flag Coverage Δ
unittests 83.55% <94.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...at/ruleset/rules/chapter3/files/IndentationRule.kt 84.94% <ø> (ø)
.../ruleset/rules/chapter3/files/FileStructureRule.kt 84.77% <94.44%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8f624...eb4902c. Read the comment docs.

@nulls nulls force-pushed the bugfix/unused_import_kdoc branch from 7f80c93 to 47781a4 Compare June 16, 2022 16:00
@nulls nulls enabled auto-merge (squash) June 16, 2022 16:01
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 256 tests   1 238 ✔️  10m 12s ⏱️
   151 suites       18 💤
   151 files           0

Results for commit eb4902c.

♻️ This comment has been updated with latest results.

@nulls nulls disabled auto-merge June 16, 2022 16:18
@nulls nulls enabled auto-merge (squash) June 16, 2022 16:22
@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 256 tests   1 238 ✔️  11m 36s ⏱️
   151 suites       18 💤
   151 files           0

Results for commit eb4902c.

@nulls nulls merged commit c98f051 into master Jun 16, 2022
@nulls nulls deleted the bugfix/unused_import_kdoc branch June 16, 2022 16:40
@nulls nulls modified the milestones: 1.1.2, 1.1.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive findings for imports that are referenced in KDOC
2 participants