Fix the compilation error (Kotlin 1.7+) #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter1/PackageNaming.kt
Fixed
Show fixed
Hide fixed
### What's done: * Non-exhaustive `if` and `when` blocks are no longer allowed when used as expressions (see <https://youtrack.jetbrains.com/issue/KT-44705>).
0x6675636b796f75676974687562
force-pushed
the
bugfix/kotlin-1.7
branch
from
09e5d1b to
d0b7226
Compare
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
============================================
- Coverage 83.68% 83.67% -0.02%
Complexity 2588 2588
============================================
Files 106 106
Lines 7386 7387 +1
Branches 2048 2048
============================================
Hits 6181 6181
- Misses 353 354 +1
Partials 852 852
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nulls
reviewed
Jun 16, 2022
| @@ -82,6 +82,9 @@ class PackageNaming(configRules: List<RulesConfig>) : DiktatRule( | |||
| } ?: if (visitorCounter.incrementAndGet() == 1) { | |||
| log.error("Not able to find an external configuration for domain" + | |||
| " name in the common configuration (is it missing in yml config?)") | |||
| } else { | |||
| @Suppress("RedundantUnitExpression") | |||
| Unit | |||
There was a problem hiding this comment.
maybe change it to a simple comment:
// do nothing
nulls
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
ifandwhenblocks are no longer allowed when used as expressions(see KT-44705).