Bugfix/indentation of multiline string #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1 new fix test * first corrected code ### Issue (#811)
* corrected code StringLiteral
* added test
### Issue(#811)
* search new bug in multiline string
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * run diktat:fix@diktat ### Issue (#811)
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests * run diktat:fix@diktat ### Issue (#811)
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests * run diktat:fix@diktat ### Issue (#811)
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests * run diktat:fix@diktat ### Issue (#811)
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests ### Issue (#811)
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests * run install * mvn fix ### Issue (#811)
nulls
reviewed
Jun 15, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Outdated
Show resolved
Hide resolved
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests * run install * mvn fix ### Issue (#811)
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
============================================
- Coverage 83.56% 83.53% -0.04%
- Complexity 2572 2579 +7
============================================
Files 106 106
Lines 7507 7523 +16
Branches 2076 2083 +7
============================================
+ Hits 6273 6284 +11
- Misses 357 358 +1
- Partials 877 881 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### Whats added: * corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * delete smoke tests * run install * mvn fix ### Issue (#811)
* corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * run install * mvn fix
nulls
approved these changes
Jun 16, 2022
* corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * corrected all WarnTest * run install * mvn fix
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Fixed
Show fixed
Hide fixed
added 3 commits
June 16, 2022 16:33
* corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * corrected all incorrect multiline string * run install * mvn fix
* corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * corrected all incorrect multiline string * run install * mvn fix
* corrected the logic of checking MultilionString * added fix test in IndentationRuleFixTest.kt - MultilionStringExpected.kt, MultilionStringTest.kt * corrected all incorrect multiline string * run install * mvn fix
0x6675636b796f75676974687562
approved these changes
Jun 16, 2022
Merged
0x6675636b796f75676974687562
added a commit
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct margins in a multiline string template
This pull request closes #811
Actions checklist