Bugfix/long line in string template

diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt

@@ -549,15 +549,17 @@ fun ASTNode.leaveExactlyNumNewLines(num: Int) {
 }
 
 /**
- * If [whiteSpaceNode] is not null and has type [WHITE_SPACE], prepend a line break to it's text.
- * Otherwise, insert a new node with a line break before [beforeNode]
+ * If [whiteSpaceNode] is not null and has type [WHITE_SPACE] and this [WHITE_SPACE] contains 1 line, prepend a line break to it's text.
+ * If [whiteSpaceNode] is null or has`t type [WHITE_SPACE], insert a new node with a line break before [beforeNode]
  *
  * @param whiteSpaceNode a node that can possibly be modified
  * @param beforeNode a node before which a new WHITE_SPACE node will be inserted
  */
 fun ASTNode.appendNewlineMergingWhiteSpace(whiteSpaceNode: ASTNode?, beforeNode: ASTNode?) {
     if (whiteSpaceNode != null && whiteSpaceNode.elementType == WHITE_SPACE) {
-        (whiteSpaceNode as LeafPsiElement).rawReplaceWithText("\n${whiteSpaceNode.text}")
+        if (whiteSpaceNode.text.lines().size == 1) {
+            (whiteSpaceNode as LeafPsiElement).rawReplaceWithText("\n${whiteSpaceNode.text}")
+        }
     } else {
         addChild(PsiWhiteSpaceImpl("\n"), beforeNode)
     }

diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/LineLengthFixTest.kt

@@ -88,4 +88,14 @@ class LineLengthFixTest : FixTestBase("test/paragraph3/long_line", ::LineLength)
     fun `fix expression in condition`() {
         fixAndCompare("LongExpressionInConditionExpected.kt", "LongExpressionInConditionTest.kt", rulesConfigListLineLength)
     }
+
+    @Test
+    fun `fix long Dot Qualified Expression`() {
+        fixAndCompare("LongDotQualifiedExpressionExpected.kt", "LongDotQualifiedExpressionTest.kt", rulesConfigListLineLength)
+    }
+
+    @Test
+    fun `fix long value arguments list`() {
+        fixAndCompare("LongValueArgumentsListExpected.kt", "LongValueArgumentsListTest.kt", rulesConfigListLineLength)
+    }
 }

diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/LineLengthWarnTest.kt

@@ -141,8 +141,8 @@ class LineLengthWarnTest : LintTestBase(::LineLength) {
                     |   }
                     |}
                 """.trimMargin(),
-            LintError(14, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 143", false),
-            LintError(18, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 142", false)
+            LintError(14, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 143", true),
+            LintError(18, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 142", true)
         )
     }
 
@@ -223,7 +223,8 @@ class LineLengthWarnTest : LintTestBase(::LineLength) {
                     |}
                 """.trimMargin(),
             LintError(8, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 130", false),
-            LintError(9, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 123", false)
+            LintError(9, 1, ruleId, "${LONG_LINE.warnText()} max line length 120, but was 123", true)
+
         )
     }
 
@@ -235,7 +236,7 @@ class LineLengthWarnTest : LintTestBase(::LineLength) {
                     |@Query(value = "ASDAASDASDASDASDASDASDASDAASDASDASDASDASDASDASDAASDASDASDASDASDASD")
                     |fun foo() = println("ASDAASDASDASDASDASDASDASDAASDASDASDASDASDASDASDAASDASDASDASDASDASD")
             """.trimMargin(),
-            LintError(1, 1, ruleId, "${LONG_LINE.warnText()} max line length 40, but was 84", false),
+            LintError(1, 1, ruleId, "${LONG_LINE.warnText()} max line length 40, but was 84", true),
             LintError(2, 1, ruleId, "${LONG_LINE.warnText()} max line length 40, but was 89", true),
             rulesConfigList = shortLineLength
         )

diktat-rules/src/test/resources/test/paragraph3/long_line/LongBinaryExpressionExpected.kt

@@ -39,8 +39,8 @@ fun foo() {
     val variable =
  Methoooooooooooooooooooooooooood() ?: "some loooooong string"
 
-    val variable = Methooooood() ?: "some" +
-" looong string"
+    val variable = Methooooood()
+ ?: "some looong string"
 
     var headerKdoc = firstCodeNode.prevSibling {
  it.elementType == KDOC

diktat-rules/src/test/resources/test/paragraph3/long_line/LongDotQualifiedExpressionExpected.kt

@@ -0,0 +1,22 @@
+package test.paragraph3.long_line
+
+val G =
+ ThisIsVeryyyyLooooonNameDooootQualifiedExpressioWithoutDot.lalalala.lalalal
+
+val A = This.Is.Veeeeryyyyyyy.Loooooong.Dot
+.Qualified.Expression
+
+val B = This?.Is?.Veeeeryyyyyyy?.Loooooong?.Dot
+?.Qualified?.Expression
+
+val C = This!!.Is!!.Veeeeryyyyyyy!!.Loooooong!!
+.Dot!!.Qualified!!.Expression
+
+val D = This.Is.Veeeeryyyyyyy.Loooooong.Dot
+    .Qualified.Expression
+
+val E = This?.Is?.Veeeeryyyyyyy?.Loooooong?.Dot
+    ?.Qualified?.Expression
+
+val F = This!!.Is!!.Veeeeryyyyyyy!!.Loooooong!!
+    .Dot!!.Qualified!!.Expression

diktat-rules/src/test/resources/test/paragraph3/long_line/LongDotQualifiedExpressionTest.kt

@@ -0,0 +1,18 @@
+package test.paragraph3.long_line
+
+val G = ThisIsVeryyyyLooooonNameDooootQualifiedExpressioWithoutDot.lalalala.lalalal
+
+val A = This.Is.Veeeeryyyyyyy.Loooooong.Dot.Qualified.Expression
+
+val B = This?.Is?.Veeeeryyyyyyy?.Loooooong?.Dot?.Qualified?.Expression
+
+val C = This!!.Is!!.Veeeeryyyyyyy!!.Loooooong!!.Dot!!.Qualified!!.Expression
+
+val D = This.Is.Veeeeryyyyyyy.Loooooong.Dot
+    .Qualified.Expression
+
+val E = This?.Is?.Veeeeryyyyyyy?.Loooooong?.Dot
+    ?.Qualified?.Expression
+
+val F = This!!.Is!!.Veeeeryyyyyyy!!.Loooooong!!
+    .Dot!!.Qualified!!.Expression

diktat-rules/src/test/resources/test/paragraph3/long_line/LongExpressionNoFixExpected.kt

@@ -3,6 +3,6 @@ package org.cqfn.diktat.resources.paragraph3.longline
 class veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong {
     // looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongggggggggggggggggggggggggg
     //looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongggggggggggggggggggggggggg
-    val s = "d" +
-" s d d d d ddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd"
+    val s =
+ "d s d d d d ddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd"
 }

diktat-rules/src/test/resources/test/paragraph3/long_line/LongInlineCommentsExpected.kt

@@ -45,7 +45,8 @@ fun foo() {
         // ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
 ElementType.IF -> handleIfElse(node)
         ElementType.EOL_COMMENT, ElementType.BLOCK_COMMENT -> handleEolAndBlockComments(node, configuration)
-        ElementType.KDOC -> handleKdocComments(node, configuration)
+        ElementType.KDOC ->
+ handleKdocComments(node, configuration)
         // ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
 else -> {
             // this is a generated else block

diktat-rules/src/test/resources/test/paragraph3/long_line/LongLineAnnotationExpected.kt

@@ -1,20 +1,28 @@
 package test.paragraph3.long_line
 
-@Query(value = "select * from test inner join" +
-" test_execution on test.id = test_execution.test_id and test_execution.st", nativeQuery = true)
+@Query(
+value = "select * from test inner join test_execution on test.id = test_execution.test_id and test_execution.st",
+ nativeQuery = true
+)
 fun retrieveBatches(limit: Int, offset: Int, executionId: Long): Some
 
-@Query(value = "select * from test inner join" +
-" test_execution on test.id = test_execution.test_id and test_execution.status = 'READY' and test_execution.test_suite_execution_id = ?3 limit ?1 offset ?2", nativeQuery = true)
+@Query(
+value = "select * from test inner join test_execution on test.id = test_execution.test_id and test_execution.status = 'READY' and test_execution.test_suite_execution_id = ?3 limit ?1 offset ?2",
+ nativeQuery = true
+)
 fun some(limit: Int, offset: Int, executionId: Long): List<Test>
 
-@Query(value = "select * from test inner joi", nativeQuery = true)
+@Query(value = "select * from test inner joi",
+ nativeQuery = true)
 fun test(limit: Int, offset: Int, executionId: Long): List<Test>
 
-@Query(value = "select * from test inner joibbb", nativeQuery = true)
+@Query(value = "select * from test inner joibbb",
+ nativeQuery = true)
 fun cornerCase(limit: Int, offset: Int, executionId: Long): List<Test>
 
-@Query(value = "select * from test inner join" +
-" test_execution on test.id = test_execution.test_id and test_execution.status = 'READY' and test_execution.test_suite_execution_id = ?3 limit ?1 offset ?2", nativeQuery = true)
+@Query(
+value = "select * from test inner join test_execution on test.id = test_execution.test_id and test_execution.status = 'READY' and test_execution.test_suite_execution_id = ?3 limit ?1 offset ?2",
+ nativeQuery = true
+)
 fun some(limit: Int, offset: Int, executionId: Long) =
  println("testtesttesttesttesttesttesttesttesttesttesttest")

diktat-rules/src/test/resources/test/paragraph3/long_line/LongLineFunExpected.kt

@@ -1,6 +1,9 @@
 package test.paragraph3.long_line
 
-fun foo() =
- println("fhdbsfkhfbvsjfkvbhjdksfvhbhhjhjhjnaljfbkshvjdsjdnlvbdkhkjncdkljskbfvhdsjndlvfkbdhfjdncjsdcscsdcsdcsdcdd")
+fun foo() = println(
+"fhdbsfkhfbvsjfkvbhjdksfvhbhhjhjhjnaljfbkshvjdsjdnlvbdkhkjncdkljskbfvhdsjndlvfkbdhfjdncjsdcscsdcsdcsdcdd"
+)
 
-fun foo () { println("fhdbsfkhfbvsjfkvbhjdksfvhbhhjhjhjnaljfbkshvjdsjdnlvbdkhkjncdkljskbfvhdsjndlvfkbdhfjdncjsdcscsdcsdcsdcdd") }
+fun foo () { println(
+"fhdbsfkhfbvsjfkvbhjdksfvhbhhjhjhjnaljfbkshvjdsjdnlvbdkhkjncdkljskbfvhdsjndlvfkbdhfjdncjsdcscsdcsdcsdcdd"
+) }

diktat-rules/src/test/resources/test/paragraph3/long_line/LongLineRValueExpected.kt

@@ -7,14 +7,14 @@ fun foo() {
     fun foo() {
         val veryLoooooooooooooooooongNamesList =
  listOf<String>("Jack", "Nick")
-        veryLoooooooooooooooooongNamesList.forEach {
- name ->
+        veryLoooooooooooooooooongNamesList
+.forEach { name ->
             if (name == "Nick") {
-                veryLoooooooooooooooooongNamesList.map { val str = "This string shouldn't be split"}
+                veryLoooooooooooooooooongNamesList
+.map { val str = "This string shouldn't be split"}
                 name.map { val str =
  "This string should be split" }
             }
-
         }
     }
 
@@ -33,10 +33,11 @@ fun foo() {
     val longStringExpression = "First part" +
  "second Part"
 
-    val longStringExpression = "First" + "second Part"
+    val longStringExpression = "First" +
+ "second Part"
 
-    val longStringExpression = "First very long" +
-" part" + "second Part"
+    val longStringExpression =
+ "First very long part" + "second Part"
 
     val longStringExpression2 =
                    "String starts at the line len limit"

diktat-rules/src/test/resources/test/paragraph3/long_line/LongShortRValueExpected.kt

@@ -1,3 +1,4 @@
 package test.paragraph3.long_line
 
-val LongWithVar2 = "${s + "a"} is a string"
+val LongWithVar2 =
+ "${s + "a"} is a string"

diktat-rules/src/test/resources/test/paragraph3/long_line/LongStringTemplateExpected.kt

@@ -3,10 +3,12 @@ object Observables {
 val someCode = 15
     // Some
 // looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line
-    @Deprecated("New type inference algorithm in Kotlin 1.4 makes this method obsolete. Method will be removed in" +
-" future RxKotlin release.",
-        replaceWith = ReplaceWith("Observable.combineLatest(source1, source2, source3, source4, combineFunction)", "io.reactivex.Observable"),
-        level = DeprecationLevel.WARNING)
+    @Deprecated(
+"New type inference algorithm in Kotlin 1.4 makes this method obsolete. Method will be removed in future RxKotlin release.",
+        replaceWith = ReplaceWith("Observable.combineLatest(source1, source2, source3, source4, combineFunction)",
+ "io.reactivex.Observable"),
+        level = DeprecationLevel.WARNING
+)
     @CheckReturnValue
     @SchedulerSupport(SchedulerSupport.NONE)
     inline fun <T1 : Any, T2 : Any, T3 : Any, T4 : Any, R : Any> combineLatest() {}
@@ -15,9 +17,12 @@ val someCode = 15
 class Foo() {
 
     fun Fuu() {
-        logger.log("<-- ${response.code} ${ if (response.message.isEmpty()) "skfnvkdjdfvd" else "dfjvndkjnbvif" +
- response.message}")
-        logger.log("<-- ${response.code} ${ if (response.message.isEmpty()) "skfnvsdcsdcscskdjdfvd" else "dfjvndsdcsdcsdcskjnbvif" + response.message}")
+        logger.log(
+"<-- ${response.code} ${ if (response.message.isEmpty()) "skfnvkdjdfvd" else "dfjvndkjnbvif" + response.message}"
+)
+        logger.log(
+"<-- ${response.code} ${ if (response.message.isEmpty()) "skfnvsdcsdcscskdjdfvd" else "dfjvndsdcsdcsdcskjnbvif" + response.message}"
+)
     }
 
     val q = """
@@ -46,4 +51,7 @@ class Foo() {
         }
     """.trimIndent()
     }
+
+    val stringName = "This is long string template with binary expression. test should be up in level binary" +
+" expression and cannot split in operation reference and should be split this long string template" + "this string should be after operated reference"
 }

diktat-rules/src/test/resources/test/paragraph3/long_line/LongStringTemplateTest.kt

@@ -38,4 +38,6 @@ class Foo() {
         }
     """.trimIndent()
     }
+
+    val stringName = "This is long string template with binary expression. test should be up in level binary expression and cannot split in operation reference and should be split this long string template" + "this string should be after operated reference"
 }

diktat-rules/src/test/resources/test/paragraph3/long_line/LongValueArgumentsListExpected.kt

@@ -0,0 +1,32 @@
+package test.paragraph3.long_line
+
+val firstArgument = 1
+val secondArgument = 2
+val thirdArgument = 3
+val fourthArgument = 4
+val fifthArguments = 5
+val sixthArguments = 6
+val seventhArguments = 7
+val eighthArguments = 8
+
+// Many arguments in function
+val result1 = ManyParamInFunction(firstArgument,
+ secondArgument, thirdArgument, fourthArgument,
+ fifthArguments, sixthArguments, seventhArguments,
+ eighthArguments)
+
+//
+val result2 = veryLongNameFun(firstArgument,
+ secondArgument)
+
+// first argument cannot to be able to stay in
+// the first line
+val result3 = veryLongNameInFirstParam(
+firstArgument, secondArgument, thirdArgument
+)
+
+// first argument cannot to be able to stay in
+// the first line
+val result4 = veryLongNameInFirstParam(
+firstArgument
+)

diktat-rules/src/test/resources/test/paragraph3/long_line/LongValueArgumentsListTest.kt

@@ -0,0 +1,22 @@
+package test.paragraph3.long_line
+
+val firstArgument = 1
+val secondArgument = 2
+val thirdArgument = 3
+val fourthArgument = 4
+val fifthArguments = 5
+val sixthArguments = 6
+val seventhArguments = 7
+val eighthArguments = 8
+
+// Many arguments in function
+val result1 = ManyParamInFunction(firstArgument, secondArgument, thirdArgument, fourthArgument, fifthArguments, sixthArguments, seventhArguments, eighthArguments)
+
+//
+val result2 = veryLongNameFun(firstArgument, secondArgument)
+
+// first argument cannot to be able to stay in the first line
+val result3 = veryLongNameInFirstParam(firstArgument, secondArgument, thirdArgument)
+
+// first argument cannot to be able to stay in the first line
+val result4 = veryLongNameInFirstParam(firstArgument)

diktat-rules/src/test/resources/test/smoke/src/main/kotlin/CheckLongLineExpected.kt

@@ -0,0 +1,3 @@
+package org.cqfn.diktat
+
+val A = This.Is.Veeeeryyyyyyy.Loooooong.Dot.Qualified.Expression

diktat-rules/src/test/resources/test/smoke/src/main/kotlin/CheckLongLineTest.kt

@@ -0,0 +1,6 @@
+package org.cqfn.diktat
+
+/**
+ * @return
+ */
+val A = This.Is.Veeeeryyyyyyy.Loooooong.Dot.Qualified.Expression