Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in copyrights rule #1155

Merged
merged 13 commits into from
Dec 23, 2021
Merged

Fixes in copyrights rule #1155

merged 13 commits into from
Dec 23, 2021

Conversation

kgevorkyan
Copy link
Member

@kgevorkyan kgevorkyan commented Dec 21, 2021

What's done:

  • HEADER_MISSING_OR_WRONG_COPYRIGHT - if pattern have obsolete year, also update it like in WRONG_COPYRIGHT_YEAR
  • If copyright have old first year, but actual last year - allow such cases
  • Add more tests
  • Enable multi release for log4j2

### What's done:
* .
### What's done:
* Codestyle
### What's done:
* readme
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* Merge master
### What's done:
* Polish
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1155 (1060af9) into master (e8007b5) will increase coverage by 0.02%.
The diff coverage is 79.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1155      +/-   ##
============================================
+ Coverage     84.72%   84.74%   +0.02%     
- Complexity     2482     2498      +16     
============================================
  Files           102      102              
  Lines          6974     6990      +16     
  Branches       1872     1881       +9     
============================================
+ Hits           5909     5924      +15     
  Misses          302      302              
- Partials        763      764       +1     
Flag Coverage Δ
unittests 84.74% <79.16%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...leset/rules/chapter2/comments/HeaderCommentRule.kt 88.80% <79.16%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8007b5...1060af9. Read the comment docs.

### What's done:
* Test
### What's done:
* WIP
@kgevorkyan kgevorkyan force-pushed the bugfix/fixes_in_copyrights branch 3 times, most recently from 1791abe to 9beea53 Compare December 22, 2021 09:49
### What's done:
* Polish
@kgevorkyan kgevorkyan force-pushed the bugfix/fixes_in_copyrights branch from 9beea53 to bd6956b Compare December 22, 2021 09:52
@kgevorkyan kgevorkyan marked this pull request as ready for review December 22, 2021 10:13
### What's done:
* Enable multi-release
### What's done:
* Add two java in CI
@kgevorkyan kgevorkyan requested a review from petertrr December 23, 2021 11:11
@kgevorkyan kgevorkyan merged commit 710ef1a into master Dec 23, 2021
@kgevorkyan kgevorkyan deleted the bugfix/fixes_in_copyrights branch December 23, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copyright text for copyright rule should be able to contain patters for current year
3 participants