Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of internal error diktat calls System.exit(1) #860

Closed
orchestr7 opened this issue Apr 28, 2021 · 0 comments · Fixed by #862
Closed

In case of internal error diktat calls System.exit(1) #860

orchestr7 opened this issue Apr 28, 2021 · 0 comments · Fixed by #862
Assignees
@orchestr7
Labels
bug Something isn't working

Comments

@orchestr7
Copy link
Member

We added this functionality to have proper logging, so we can suggest to create an issue in our repository
But this is breaking a diktat-demo. We need to throw ERROR instead of exitProcess()
@orchestr7 orchestr7 added the bug Something isn't working label Apr 28, 2021
@orchestr7 orchestr7 self-assigned this Apr 28, 2021
orchestr7 added a commit that referenced this issue Apr 28, 2021
@orchestr7
Removing System.exit(1)
2f9e5f1 
### What's done:
- we decided to remove System.exit(1) because of the diktat demo #860
- fixed logging
@orchestr7 orchestr7 mentioned this issue Apr 28, 2021
Merged
orchestr7 added a commit that referenced this issue Apr 29, 2021
@orchestr7
Removing System.exit(1) (#862)
4c9ebf8 
Removing System.exit(1)

### What's done:
- we decided to remove System.exit(1) because of the diktat demo #860
- fixed logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orchestr7 orchestr7

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing System.exit(1) saveourtool/diktat
1 participant
@orchestr7