Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAVE smoke tests SHOULD NOT have fixed line numbers! #1527

Closed
orchestr7 opened this issue Sep 14, 2022 · 0 comments · Fixed by #1528
Closed

SAVE smoke tests SHOULD NOT have fixed line numbers! #1527

orchestr7 opened this issue Sep 14, 2022 · 0 comments · Fixed by #1528
Assignees
@Cheshiriks
Labels
bug Something isn't working tests Improve testing
Milestone
1.2.4

Comments

@orchestr7
Copy link
Member

orchestr7 commented Sep 14, 2022 •
edited
Loading

Fix it asap and remove hardcoded line numbers in tests
@orchestr7 orchestr7 added the bug Something isn't working label Sep 14, 2022
@petertrr petertrr added the tests Improve testing label Sep 15, 2022
Cheshiriks added a commit that referenced this issue Sep 15, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
ba77aa3 
### What's done:
* replace line numbers with placeholder
Closes #1527
@Cheshiriks Cheshiriks mentioned this issue Sep 15, 2022
Merged
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
5ce5018 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
f1394bf 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
30659f1 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
643cc3c 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
58fdc27 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
9069946 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers
895f520 
### What's done:
* replace line numbers with placeholder
Closes #1527
Cheshiriks added a commit that referenced this issue Sep 16, 2022
@Cheshiriks
SAVE smoke tests should not have fixed line numbers (#1528)
f6fa2cd 
* SAVE smoke tests should not have fixed line numbers

### What's done:
* replace line numbers with placeholder
Closes #1527
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.4 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheshiriks Cheshiriks

Labels
bug Something isn't working tests Improve testing
Projects
None yet
Milestone
1.2.4
Development

Successfully merging a pull request may close this issue.

SAVE smoke tests should not have fixed line numbers saveourtool/diktat
4 participants
@petertrr @Cheshiriks @orchestr7 @0x6675636b796f75676974687562