feature/inline-classes(#698)

### What's done: * Fixed bugs
saveourtool · Jan 19, 2021 · 7816893 · 7816893
1 parent 3a3e1a2
commit 7816893
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/InlineClassesRule.kt b/diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/InlineClassesRule.kt
@@ -54,7 +54,9 @@ class InlineClassesRule(private val configRule: List<RulesConfig>) : Rule("inlin
         if (classPsi.getProperties().size == 1 && !classPsi.hasExplicitPrimaryConstructor()) {
             return !classPsi.getProperties().first().isVar
         } else if (classPsi.getProperties().isEmpty() && classPsi.hasExplicitPrimaryConstructor()) {
-            return classPsi.primaryConstructorParameters.size == 1 && !classPsi.primaryConstructorParameters.first().node.hasChildOfType(VAR_KEYWORD)
+            return classPsi.primaryConstructorParameters.size == 1
+                    && !classPsi.primaryConstructorParameters.first().node.hasChildOfType(VAR_KEYWORD)
+                    && classPsi.primaryConstructorModifierList == null
         }
         return false
     }

diff --git a/diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter6/InlineClassesWarnTest.kt b/diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter6/InlineClassesWarnTest.kt
@@ -112,4 +112,16 @@ class InlineClassesWarnTest : LintTestBase(::InlineClassesRule) {
             """.trimMargin()
         )
     }
+
+    @Test
+    @Tag(WarningNames.INLINE_CLASS_CAN_BE_USED)
+    fun `should not trigger on class with internal constructor`() {
+        lintMethod(
+            """
+            |class LocalCommandExecutor internal constructor(private val command: String) {
+            |   val some = 3
+            |}
+        """.trimMargin()
+        )
+    }
 }