Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Closure at min and max date #49

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

stephanus-tantiono
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Oct 27, 2023

PR Summary 📑

  • Added the power of 'Closure' 🧩
    In this update, we're making use of something called 'Closure' - essentially a fancy term for a function that can remember the environment in which it was created, which is pretty neat! This was added at the very top of the file to signal that we want to use this special functionality.

  • Levelled Up $maxDate and $minDate 🚀
    We revamped the type of $maxDate and $minDate properties. They've now leveled up to include Closure. This basically means they're more flexible now and can do more stuff than before!

  • Tweaked maxDate() and minDate() methods for more power 💪
    Both the maxDate() and minDate() methods have received a tweak. They now can accept Closure as an argument. This means they can better adapt and offer more precise results. Ingenious modifications here are boosting the program's ability to deal with dates.

Let's continue making the code world a better place! 😄🌏✨

@ziming
Copy link

ziming commented Dec 1, 2023

I'm interested in this too!

@coolsam726 coolsam726 merged commit e255ae1 into savannabits:3.x Mar 21, 2024
1 check passed
@idealerror
Copy link

idealerror commented Jul 1, 2024

@coolsam726 This PR merge is breaking the package. I suggest reverting the Closure change on minDate and maxDate.

@stephanus-tantiono
Copy link
Contributor Author

#58 this Pr should fix the mistake in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants