Changed address opened in browser to 127.0.0.1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in reference to the golang issue#22827 and the commit 661f3f1, which says 'Sending to 0.0.0.0 doesn't seem to work on Windows.' And I can confirm: It doesn't run, on my windows system at least. Also I removed the other binaries.
|
Hi. Thanks for mentioning the issue. I will try to pick your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to the golang issue#22827 and the commit 661f3f1, which says
And I can confirm: It doesn't run, on my windows system at least. It might also solve the issue #1. Weird, since it is a mac, but the error stack looks a lot like what I got earlier.
It's not the prettiest solution, but I think this is more of a go issue.
Also I removed the other binaries.