Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use command line git diff --name-only base..head for diff strategy #57

Merged
merged 11 commits into from
Mar 18, 2024

Conversation

cwbusacker
Copy link
Contributor

@cwbusacker cwbusacker commented Mar 13, 2024

Resolves: #52

@saurav0705
Copy link
Owner

saurav0705 commented Mar 13, 2024

Resolves: #52 I have not been able to test this. How have you been doing your testing?

@cwbusacker
I have another repo where I am running the checks you can do the same just mention the feature branch inside the git action instead of the version
example: saurav0705/check-history-action@more-than-300-files
for now, you can just test the function i will check the workflow

@cwbusacker
Copy link
Contributor Author

cwbusacker commented Mar 13, 2024

Wont I need the dist check to run first? Looks like the dist check waits for approval before running

src/github/get-diff-from-commit.ts Outdated Show resolved Hide resolved
src/regex-match-for-files.ts Show resolved Hide resolved
@cwbusacker cwbusacker marked this pull request as draft March 13, 2024 18:41
@cwbusacker cwbusacker changed the title Loop through pages of files to handle more than 300 files Use command line git diff --name-only base..head for diff strategy Mar 14, 2024
@cwbusacker
Copy link
Contributor Author

Wont I need the dist check to run first? Looks like the dist check waits for approval before running

Nevermind. I read over that workflow and ran it manually locally.

@cwbusacker cwbusacker requested a review from saurav0705 March 14, 2024 13:40
@cwbusacker cwbusacker marked this pull request as ready for review March 14, 2024 13:40
@cwbusacker
Copy link
Contributor Author

cwbusacker commented Mar 14, 2024

This is working.

Copy link
Owner

@saurav0705 saurav0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the fetch change else it looks good

Fix with git fetch

Co-authored-by: Saurav Aggarwal <[email protected]>
@cwbusacker cwbusacker requested a review from saurav0705 March 16, 2024 19:39
@cwbusacker
Copy link
Contributor Author

cwbusacker commented Mar 16, 2024

make the fetch change else it looks good

Did that. Didn't think that was necessary since the check-out step just happened....

But appears your suggested changes had compilation errors, so had to fix that.

dist/licenses.txt Outdated Show resolved Hide resolved
@saurav0705
Copy link
Owner

make the fetch change else it looks good

Did that. Didn't think that was necessary since the check-out step just happened....

But appears your suggested changes had compilation errors, so had to fix that.

@cwbusacker
yeah but that hold true only if it's deep clone if a person is doing shallow clone or cloning with a depth then we might run into this issue

@saurav0705 saurav0705 merged commit 09a4b8b into saurav0705:main Mar 18, 2024
1 check passed
@cwbusacker cwbusacker deleted the more-than-300-files branch March 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't check over 300 files
2 participants