Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: revert log level to int #847

Merged
merged 2 commits into from
Jun 18, 2024
Merged

log: revert log level to int #847

merged 2 commits into from
Jun 18, 2024

Conversation

Choraden
Copy link
Contributor

The previous idea was wrong. String type messes up the order of log levels.
We will shift it.

Choraden added 2 commits June 18, 2024 10:21
That would eliminate the zero value issue with flags.

Fixes #832
@Choraden Choraden merged commit f7b0956 into main Jun 18, 2024
6 checks passed
@Choraden Choraden deleted the hg/rev_log_level branch June 18, 2024 09:21
@mmatczuk
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants