-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: extend log-http flag docs and better explain syntax of flags supporting multiple data sources #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mode cannot be empty if Logger is correctly constructed.
--log-http [api|proxy:]<none|short-url|url|headers|body|errors>,... (default errors) (env FORWARDER_LOG_HTTP)
According to HTML spec > The <br> HTML element produces a line break in text (carriage-return). It is useful for writing a poem or an address, where the division of lines is significant. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br
Choraden
reviewed
May 21, 2024
# the documentation for the -H, --header flag for more details on the format. | ||
# Use --connect-header flag instead. | ||
# | ||
DEPRECATED: --connect-header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated notice should be also commented, shouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
Apart from the deprecated notice LGTM |
Trim additional space that may be added if usage ends with </ul>
@Choraden PTAL |
mmatczuk
changed the title
docs: extend log-http flag docs
docs: extend log-http flag docs and better explain syntax of flags supporting multiple data sources
May 21, 2024
Choraden
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes in flags