Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind: fix --proxy flag usage #786

Merged
merged 1 commit into from
Apr 22, 2024
Merged

bind: fix --proxy flag usage #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bind/flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,10 @@ func HTTPProxyConfig(fs *pflag.FlagSet, cfg *forwarder.HTTPProxyConfig, lcfg *lo
LogConfig(fs, lcfg)

fs.VarP(anyflag.NewValueWithRedact[*url.URL](cfg.UpstreamProxy, &cfg.UpstreamProxy, forwarder.ParseProxyURL, RedactURL),
"proxy", "x", "[protocol://]host[:port]"+
"proxy", "x", "<[protocol://]host:port>"+
"Upstream proxy to use. "+
"The supported protocols are: http, https, socks5. "+
"No protocol specified will be treated as HTTP proxy. "+
"If the port number is not specified, it is assumed to be 1080. "+
"The basic authentication username and password can be specified in the host string e.g. user:pass@host:port. "+
"Alternatively, you can use the -c, --credentials flag to specify the credentials. "+
"If both are specified, the proxy flag takes precedence. ")
Expand Down
Loading