Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

martian: use localhost for testing #715

Merged
merged 1 commit into from
Feb 23, 2024
Merged

martian: use localhost for testing #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions internal/martian/proxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (l listener) dial() (net.Conn, error) {
func newListener(t *testing.T) listener {
t.Helper()

l, err := net.Listen("tcp", "[::]:0")
l, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -253,7 +253,7 @@ func TestIntegrationHTTP100Continue(t *testing.T) {

setTimeout(p, 2*time.Second)

sl, err := net.Listen("tcp", "[::]:0")
sl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -362,7 +362,7 @@ func TestIntegrationHTTP101SwitchingProtocols(t *testing.T) {

setTimeout(p, 200*time.Millisecond)

sl, err := net.Listen("tcp", "[::]:0")
sl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -476,7 +476,7 @@ func TestIntegrationUnexpectedUpstreamFailure(t *testing.T) {
// setting a large proxy timeout
setTimeout(p, 1000*time.Second)

sl, err := net.Listen("tcp", "[::]:0")
sl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -569,7 +569,7 @@ func TestIntegrationHTTPUpstreamProxy(t *testing.T) {
t.Parallel()

// Start first proxy to use as upstream.
ul, err := net.Listen("tcp", "[::]:0")
ul, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -639,7 +639,7 @@ func TestIntegrationHTTPUpstreamProxyError(t *testing.T) {

// Set proxy's upstream proxy to invalid host:port to force failure.
p.ProxyURL = http.ProxyURL(&url.URL{
Host: "[::]:0",
Host: "localhost:0",
})
setTimeout(p, 600*time.Millisecond)

Expand Down Expand Up @@ -704,7 +704,7 @@ func TestIntegrationTLSHandshakeErrorCallback(t *testing.T) {
mc.SetHandshakeErrorCallback(func(_ *http.Request, err error) { herr = errors.New("handshake error") })
p.MITMConfig = mc

tl, err := net.Listen("tcp", "[::]:0")
tl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("tls.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -792,7 +792,7 @@ func TestIntegrationConnect(t *testing.T) { //nolint:tparallel // Subtests share
t.Fatalf("mitm.NewConfig(): got %v, want no error", err)
}

tl, err := net.Listen("tcp", "[::]:0")
tl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("tls.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -948,7 +948,7 @@ func TestIntegrationConnectUpstreamProxy(t *testing.T) {
t.Parallel()

// Start first proxy to use as upstream.
ul, err := net.Listen("tcp", "[::]:0")
ul, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -1152,7 +1152,7 @@ func TestIntegrationConnectTerminateTLS(t *testing.T) {
}
p.RoundTripper = rt

tl, err := net.Listen("tcp", "[::]:0")
tl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("tls.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -1411,7 +1411,7 @@ func TestIntegrationTransparentMITM(t *testing.T) {
//
// BUG: tls.Listen will not accept a tls.Config where Certificates is empty,
// even though it is supported by tls.Server when GetCertificate is not nil.
l, err := net.Listen("tcp", "[::]:0")
l, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -1753,7 +1753,7 @@ func TestTLSHandshakeTimeoutWithMITM(t *testing.T) {
func TestServerClosesConnection(t *testing.T) {
t.Parallel()

dstl, err := net.Listen("tcp", "[::]:0")
dstl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("Failed to create http listener: %v", err)
}
Expand Down Expand Up @@ -1788,7 +1788,7 @@ func TestServerClosesConnection(t *testing.T) {
conn.Close()
}()

l, err := net.Listen("tcp", "[::]:0")
l, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -1858,7 +1858,7 @@ func TestRacyClose(t *testing.T) {
t.Parallel()

openAndConnect := func() {
l, err := net.Listen("tcp", "[::]:0")
l, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down Expand Up @@ -1993,7 +1993,7 @@ func TestConnectRequestModifier(t *testing.T) {
return nil
}

tl, err := net.Listen("tcp", "[::]:0")
tl, err := net.Listen("tcp", "localhost:0")
if err != nil {
t.Fatalf("net.Listen(): got %v, want no error", err)
}
Expand Down
Loading