Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC e2e test #646

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Add gRPC e2e test #646

merged 4 commits into from
Jan 12, 2024

Conversation

mmatczuk
Copy link
Contributor

No description provided.

@mmatczuk
command/grpctest: add gRPC test server
039e516 
Run the Martian h2 test service as a standalone server.
@mmatczuk
command/forwarder: add gRPC test server to root command
59b4b23
@mmatczuk
command: move httpbin and grpctest under test command
9384942 
Add test command and rename grpctest to "test grpc", httpbin is now "test httpbin".
The commands are not hidden anymore and the help shows:

Other Commands:
  completion    Generate the autocompletion script for the specified shell
  test          Run test servers for various protocols
  version       Print version information
@mmatczuk mmatczuk requested a review from a team as a code owner January 10, 2024 14:17
@mmatczuk
e2e: add gRPC tests
776cbff 
The tests are ported from Martian h2 tests.
The client is called fixture for compatibility reasons.
@Choraden
Copy link
Contributor

Choraden commented Jan 10, 2024 •
edited
Loading

LGTM

I wish we had a better solution to configure test env: t.Setenv("HTTPS_PROXY", proxy) // set proxy for grpc.Dial and
$(shell docker inspect forwarder-e2e-httpbin-1 --format='{{ range .Config.Env }}{{ if eq "FORWARDER" (slice . 0 9) }} -e "HTTPBIN{{slice . 9}}"{{end}}{{end}}' 2> /dev/null).

@mmatczuk
Copy link
Contributor Author

I'm open to rewrite possibilities.

@mmatczuk mmatczuk merged commit 991263e into main Jan 12, 2024
4 checks passed
@mmatczuk mmatczuk deleted the mmt/grpc_test branch January 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Choraden Choraden Choraden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatczuk @Choraden