Eager listener init #405
Merged
Eager listener init #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listener injection is not used and collides with the followup changes.
mmatczuk
force-pushed
the
mmt/eager_listener_init
branch
from
5ac4afa to
9f348bd
Compare
|
I don't like that there is more the one subject which closes the listener i.e. |
|
How about documenting that one needs to close the Proxy once created? |
It's needed in case of martian so that it stop listening, it is indeed wrong. |
This moves network address availability from runtime to initialization / creation. With that it's not possible to create two servers with the same address. This is better for error reporting. If runctx is used we can fail fast if we know we will not be able to start listener.
|
Added comments. |
|
I'm wondering if we could add |
This moves network address availability from runtime to initialization / creation.
mmatczuk
force-pushed
the
mmt/eager_listener_init
branch
from
9f348bd to
995b769
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.