refactor recent changes to martian logging #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatczuk
reviewed
Sep 7, 2023
internal/martian/log/log.go
Outdated
Comment on lines
44
to
46
| if v := ctx.Value(TraceContextKey); v != nil { | ||
| format = fmt.Sprintf("[%s] %s", v, format) | ||
| } |
There was a problem hiding this comment.
This is repeated 3 times, maybe extract that to function?
|
This probably can be squashed martian(handler): use context logging functions Hubert Grochowski Yesterday 16:30 |
|
I suggest to move the cutting of martian log prefix to martian log functions instead of doing cmd/forarder/run: apply more advanced logic to cut |
This allows use to print logs with trace id.
Logs in these files does not need to be traced.
Since martian logger appends trace id to the format this in an easy patch to make the log line look ok. [proxy] DEBUG: [18a6b0c67a1] msg -> [proxy] [DEBUG] [18a6b0c67a1] msg
This makes the logs more flexible as one can add any prefix by Deocrate function in logger.
The martian prefix has been removed from the log lines for good. It is no longer needed to decorate the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Example log message: