utils/cobrautil: support pasring lists from env vars and config file #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trims and reformats string values set from viper.
It allows reading yaml and json format lists e.g.
```
dns-server:
- 1.2.3.4
- 4.3.2.1
```
```
{
"dns-server": ["8.8.8.8", "5.5.5.5"]
}
```
and env vars:
```
FORWARDER_DNS_SERVER="1.2.3.4 4.3.2.1" forwarder run
```
It does not affect reading and parsing flags from command line.
waggledans
reviewed
Sep 1, 2023
| @@ -55,7 +55,11 @@ func BindAll(cmd *cobra.Command, envPrefix, configFileFlagName string) error { | |||
| ok = true | |||
| fs.VisitAll(func(f *pflag.Flag) { | |||
| if !f.Changed && v.IsSet(f.Name) { | |||
| if err := fs.Set(f.Name, fmt.Sprintf("%v", v.Get(f.Name))); err != nil { | |||
| s := fmt.Sprintf("%v", v.Get(f.Name)) | |||
| s = strings.TrimPrefix(s, "[") | |||
There was a problem hiding this comment.
Is it because we don't have access to the anyflag repo right now? I think it could wait a few days (unless it's problematic to fix in anyflag)
There was a problem hiding this comment.
After investigation, it turns out that anyflag follows parsing rules of cobra, so we probably don't want to mess with it.
More advanced parsing is usually implemented in a higher layer and later passed to cobra like I've done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trims and reformats string values set from viper. It allows reading yaml and json format lists e.g.
and env vars:
It does not affect reading and parsing flags from command line.