Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Excess found: excess = 2 url = / (zero-length body) in HEAD response #358

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

mmatczuk
Copy link
Contributor

@mmatczuk mmatczuk commented Aug 14, 2023

We need e2e HEAD test:

  • with and without body
  • Transfer-Encoding: (none just content-length), chunked, identity

@what-the-diff
Copy link

what-the-diff bot commented Aug 14, 2023

PR Summary

  • Error Handling Enhanced in Callback Setup
    If there are any issues during execution, these will now be reported more accurately. This was achieved by changing the code to return an error if the error outputs (stderr) is not empty.

  • Improvements to Handler.go in Terms of Handling Empty Body
    There were some adjustments made to correctly handle cases where the body is http.NoBody. This ensures a more stable performance even when the body data is missing.

  • Addition of head.go
    A new file named head.go has been introduced to the code. Although the details of what this new file does weren't shared, its addition will likely provide some great new functionality.

  • TEST Upgrades in httpspec_test.go
    New testing measures have been inserted to ensure the proper operation of our services. To be specific, the Transfer-Encoding header was added to the request and response headers in our tests.

  • Modification in Proxy API Responses
    Changes were made to manually write the response for HEAD requests with no body, ensuring an optimal response handling. Server-Sent Events (SSE) will now be treated more efficiently by flushing after each chunk.

Copy link
Contributor

@Choraden Choraden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Choraden Choraden merged commit 824b020 into main Aug 31, 2023
@Choraden Choraden deleted the mmt/head branch August 31, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants