Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: stop using go:linkname #895

Closed
mmatczuk opened this issue Sep 4, 2024 · 2 comments
Closed

net: stop using go:linkname #895

mmatczuk opened this issue Sep 4, 2024 · 2 comments
Assignees
Milestone

Comments

@mmatczuk
Copy link
Contributor

mmatczuk commented Sep 4, 2024

Go 1.23 prevents us from accessing unexpected parts of standard library.

At the moment we use

  1. config.go://go:linkname isDomainName net.isDomainName
  2. utils/osdns/resolvconf.go://go:linkname resolvConf net.resolvConf
  3. utils/osdns/resolvconf.go://go:linkname getSystemDNSConfig net.getSystemDNSConfig
  4. resolver.go://go:linkname lookupStaticHost net.lookupStaticHost

We need to figure out what to do case by case.

@mmatczuk mmatczuk added this to the v1.4 milestone Sep 4, 2024
mmatczuk added a commit that referenced this issue Sep 4, 2024
Go 1.23 forbids go:linkname and thus prevents the build.
Disable the check and continue business as usual.

This commit shall be reverted when we can get rid of go:linkname.

Relates to #895
@mmatczuk
Copy link
Contributor Author

mmatczuk commented Sep 4, 2024

Caused by #894

mmatczuk added a commit that referenced this issue Sep 4, 2024
Go 1.23 forbids go:linkname and thus prevents the build.
Disable the check and continue business as usual.

This commit shall be reverted when we can get rid of go:linkname.

Relates to #895
mmatczuk added a commit that referenced this issue Sep 4, 2024
Go 1.23 forbids go:linkname and thus prevents the build.
Disable the check and continue business as usual.

This commit shall be reverted when we can get rid of go:linkname.

Relates to #895
mmatczuk added a commit that referenced this issue Sep 4, 2024
Go 1.23 forbids go:linkname and thus prevents the build.
Disable the check and continue business as usual.

This commit shall be reverted when we can get rid of go:linkname.

Relates to #895
@mmatczuk mmatczuk changed the title net: using go:linkname net: stop using go:linkname Sep 5, 2024
@mmatczuk mmatczuk self-assigned this Sep 5, 2024
@mmatczuk
Copy link
Contributor Author

mmatczuk commented Sep 5, 2024

//go:linkname isDomainName net.isDomainName is OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant