Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

martian: fix handling of no route to host in Windows #493

Closed
mmatczuk opened this issue Nov 2, 2023 · 0 comments · Fixed by #732
Closed

martian: fix handling of no route to host in Windows #493

mmatczuk opened this issue Nov 2, 2023 · 0 comments · Fixed by #732
Milestone
v1.2

Comments

@mmatczuk
Copy link
Contributor

mmatczuk commented Nov 2, 2023

In Windows we can see the following logs

[error] failed to CONNECT: dial tcp [IPv6]:443: connectex: A socket operation was attempted to an unreachable network.

This error better know as WSAENETUNREACH 10051 (0x2743) is Windows equivalent of no route to host.

We should handle it and respond with 502 Bad Gateway.
@mmatczuk mmatczuk added this to the v1.2 milestone Nov 2, 2023
@mmatczuk mmatczuk changed the title martian: fix handling on no route to host in Windows martian: fix handling of no route to host in Windows Nov 2, 2023
mmatczuk added a commit that referenced this issue Mar 4, 2024
@mmatczuk
http_proxy(errors): windows return status 502 for WSAENETUNREACH error
93a8ccb 
Add handleWindowsNetError to handler list directly for simplicity.
Adding OS build tags and additional code infrastructure is not worth the effort hance the check is added for all platforms.

Fixes #493
@mmatczuk mmatczuk mentioned this issue Mar 4, 2024
Merged
mmatczuk added a commit that referenced this issue Mar 4, 2024
@mmatczuk
http_proxy(errors): windows return status 502 for WSAENETUNREACH error
b588907 
Add handleWindowsNetError to handler list directly for simplicity.
Adding OS build tags and additional code infrastructure is not worth the effort hance the check is added for all platforms.

Fixes #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

http_proxy(errors): windows return status 502 for WSAENETUNREACH error saucelabs/forwarder
1 participant
@mmatczuk