martian: use isClosedConnError instead of isCloseable outside of hand…

…leLoop
saucelabs · Oct 17, 2023 · 2dece1d · 2dece1d
1 parent 4474a8d
commit 2dece1d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/martian/proxy.go b/internal/martian/proxy.go
@@ -410,7 +410,7 @@ func (p *Proxy) readRequest(ctx *Context, conn net.Conn, brw *bufio.ReadWriter)
 
 	req, err = http.ReadRequest(brw.Reader)
 	if err != nil {
-		if isCloseable(err) {
+		if isClosedConnError(err) {
 			log.Debugf(context.TODO(), "connection closed prematurely: %v", err)
 		} else {
 			log.Errorf(context.TODO(), "failed to read request: %v", err)

diff --git a/internal/martian/proxy_test.go b/internal/martian/proxy_test.go
@@ -1825,7 +1825,7 @@ func TestReadHeaderTimeout(t *testing.T) {
 	if _, err = conn.Write([]byte("Host: example.com\r\n\r\n")); err != nil {
 		t.Fatalf("conn.Write(): got %v, want no error", err)
 	}
-	if _, err = conn.Read(make([]byte, 1)); !errors.Is(err, io.EOF) {
+	if _, err = conn.Read(make([]byte, 1)); !isClosedConnError(err) {
 		t.Fatalf("conn.Read(): got %v, want io.EOF", err)
 	}
 }