Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove eth_getLogs hardcode #94

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix: remove eth_getLogs hardcode #94

merged 1 commit into from
Jan 25, 2023

Conversation

brianluong
Copy link
Member

@brianluong brianluong commented Jan 25, 2023 •
edited
Loading

Description

We already have the new node-gateway-config in place already to disable eth_getLogs on specific full nodes (bor + geth). This hack is safe to remove.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 😎 New feature (non-breaking change which adds functionality)
  • ⁉️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚒️ Refactor (no functional changes)
  • 📖 Documentation (updating or adding docs)

dianwen
dianwen approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@dianwen dianwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!!

@brianluong brianluong merged commit 233694a into main Jan 25, 2023
@brianluong brianluong deleted the remove_eth_getLogs_hardcode branch January 25, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianwen dianwen dianwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianluong @dianwen