fix: set http server idle timeout to 2 minutes #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianwen
force-pushed
the
set-http-server-idle-timeout
branch
from
cc576b5
to
fb739b7
Compare
brianluong
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ALB idle timeout for keepalive conns is 60 sec. If we have a lower value than that, the connection could be dropped causing 502s. https://medium.com/@_alif/aws-elb-5xxs-revisit-your-server-keepalivetimeout-a0ea8e22c242
It doesn't seem like there's a timeout by default, but doesn't hurt to add this.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.