Trace filter #76
Merged
Trace filter #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianluong
force-pushed
the
trace_filter
branch
from
259a0ee
to
4158ed6
Compare
dianwen
reviewed
Oct 13, 2022
| @@ -10,7 +10,7 @@ func (p *RequestMetadataParser) Parse(requestBody jsonrpc.RequestBody) RequestMe | |||
| result := RequestMetadata{} | |||
|
|
|||
| switch requestBody.Method { | |||
| case "eth_getBalance", "eth_getStorageAt", "eth_getTransactionCount", "eth_getCode", "eth_call", "eth_estimateGas": | |||
| case "eth_getBalance", "eth_getStorageAt", "eth_getTransactionCount", "eth_getCode", "eth_call", "eth_estimateGas", "trace_filter": | |||
There was a problem hiding this comment.
Should we update the documentation to match the behavior change? Everything says state right now. We can change it to StateAndTrace and clarify w/ comments.
Mind also adding these trace methods? https://openethereum.github.io/JSONRPC-trace-module#:~:text=G%3A%20%5B1%2C%200%5D%7D%20%5D-,JSON%2DRPC%20methods,-Ad%2Dhoc%20Tracing
dianwen
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
state method
Type of change
How Has This Been Tested?
none