-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: route state-backed requests to archive nodes #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
result := RequestMetadata{} | ||
|
||
switch requestBody.Method { | ||
case "eth_getBalance", "eth_getStorageAt", "eth_getTransactionCount", "eth_getCode", "eth_call", "eth_estimateGas": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we include add a link to the Eth docs that say which methods are state methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good point! Added.
aadd18b
to
704f56f
Compare
77adc51
to
3c81aab
Compare
704f56f
to
cef5348
Compare
3c81aab
to
53cd98e
Compare
53cd98e
to
c989bcf
Compare
Description
nodeType
to theUpstreamConfig
so that we know which nodes maintain full historic state.Type of change
How Has This Been Tested?
Unit tests for the
RequestMetadataParser
andSimpleIsStatePresentFilter
.