Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make sure commit msg starts with lower case after the commit type #54

Merged
merged 1 commit into from
Aug 31, 2022
Merged

ci: make sure commit msg starts with lower case after the commit type #54

merged 1 commit into from
Aug 31, 2022

Conversation

brianluong
Copy link
Member

@brianluong brianluong commented Aug 31, 2022 •
edited
Loading

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 😎 New feature (non-breaking change which adds functionality)
  • ⁉️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚒️ Refactor (no functional changes)
  • 📖 Documentation (updating or adding docs)

How Has This Been Tested?

➜  node-gateway git:(more_metrics) ✗ ./scripts/lint_commit_message.sh "fix: H"
Commit message does follow the conventional commit format.
➜  node-gateway git:(more_metrics) ✗ ./scripts/lint_commit_message.sh "fix: h"
➜  node-gateway git:(more_metrics) ✗ ./scripts/lint_commit_message.sh "fix: hi"

@jonathankau
Copy link
Member

Thanks for updating!

@brianluong brianluong merged commit 8cbf5dd into main Aug 31, 2022
@brianluong brianluong deleted the lower_case_ci branch August 31, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathankau jonathankau jonathankau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianluong @jonathankau