style: introduce an enum for NodeFilter types

satsuma-xyz · Sep 19, 2022 · 7d2615c · 7d2615c
1 parent 18d02fe
commit 7d2615c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/internal/route/node_filter.go b/internal/route/node_filter.go
@@ -66,7 +66,7 @@ func (f *IsAtMaxHeightForGroup) Apply(_ *RequestMetadata, upstreamConfig *config
 }
 
 func CreateNodeFilter(
-	filterNames []string,
+	filterNames []NodeFilterType,
 	manager checks.HealthCheckManager,
 	store *metadata.ChainMetadataStore,
 ) NodeFilter {
@@ -79,19 +79,19 @@ func CreateNodeFilter(
 }
 
 func CreateSingleNodeFilter(
-	filterName string,
+	filterName NodeFilterType,
 	manager checks.HealthCheckManager,
 	store *metadata.ChainMetadataStore,
 ) NodeFilter {
 	switch filterName {
-	case "healthy":
+	case IsHealthy:
 		return &IsHealthyFilter{manager}
-	case "globalMaxHeight":
+	case GlobalMaxHeight:
 		return &IsAtGlobalMaxHeight{
 			healthCheckManager: manager,
 			chainMetadataStore: store,
 		}
-	case "maxHeightForGroup":
+	case MaxHeightForGroup:
 		return &IsAtMaxHeightForGroup{
 			healthCheckManager: manager,
 			chainMetadataStore: store,
@@ -100,3 +100,11 @@ func CreateSingleNodeFilter(
 		panic("Unknown filter type " + filterName + "!")
 	}
 }
+
+type NodeFilterType string
+
+const (
+	IsHealthy         NodeFilterType = "healthy"
+	GlobalMaxHeight                  = "globalMaxHeight"
+	MaxHeightForGroup                = "maxHeightForGroup"
+)
diff --git a/internal/server/web_server.go b/internal/server/web_server.go
@@ -68,7 +68,7 @@ func wireRouter(config conf.Config) route.Router {
 	ticker := time.NewTicker(checks.PeriodicHealthCheckInterval)
 	healthCheckManager := checks.NewHealthCheckManager(client.NewEthClient, config.Upstreams, chainMetadataStore, ticker)
 
-	nodeFilter := route.CreateNodeFilter([]string{"healthy", "maxHeightForGroup"}, healthCheckManager, chainMetadataStore)
+	nodeFilter := route.CreateNodeFilter([]route.NodeFilterType{route.IsHealthy, route.MaxHeightForGroup}, healthCheckManager, chainMetadataStore)
 	routingStrategy := route.FilteringRoutingStrategy{
 		NodeFilter:      nodeFilter,
 		BackingStrategy: route.NewPriorityRoundRobinStrategy(),