Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of testnet UI #1158

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ebma
Copy link
Member

@ebma ebma commented Nov 2, 2020

Changes the color of primary and submit buttons when using a testnet account and testnet badges to a pink color. This way the user always has a more obvious indicator when doing things with a testnet account. Admittedly,
this is a rather eye-catching color but then again the goal is to make the user aware he is not using mainnet at the moment.

  • Add a testnet prop to the <ActionButton> component
  • Add colors for testnet to the theme
  • Show the pink color for action buttons when the testnet prop is set and the button is of type primary or submit
  • Allow same account name for accounts on different networks

Closes #1010.

Screenshot 2020-11-11 at 10 01 17

Screenshot 2020-11-11 at 10 01 25

Screenshot 2020-11-11 at 10 01 33

@ebma ebma force-pushed the feature/1010-highlight-testnet-ui-more-prominently branch from 9ba0d99 to 099772a Compare November 2, 2020 12:03
@ebma ebma force-pushed the feature/1010-highlight-testnet-ui-more-prominently branch from 099772a to 6265749 Compare November 11, 2020 09:05
@andywer
Copy link
Contributor

andywer commented Nov 11, 2020

@ebma One last thing: Let's make all testnet badges magenta then, incl. the one on the account view header 😉

@ebma
Copy link
Member Author

ebma commented Nov 11, 2020

Done. Looks like this:
Screenshot 2020-11-11 at 11 16 38

By the way I noticed that the title of the trading dialog does not have a testnet badge next to it. Seems like a mistake since it's in most other relevant dialogs @andywer?

@andywer
Copy link
Contributor

andywer commented Nov 11, 2020

@ebma Yes, let's add the badge to the trading dialog, too 👍

@ebma
Copy link
Member Author

ebma commented Nov 11, 2020

I've added the testnet badge in a separate PR #1164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight testnet UI more prominently
2 participants