Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add master as trigger for Integration-Checks #9564

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

dcollins15
Copy link
Contributor

@dcollins15 dcollins15 commented Dec 20, 2024

Picking up where #9538 left off, this PR:

  1. Drops the AppVeyor CI pipeline by removing the appveyor.yml file, per my the plan laid out here
  2. Adds master as a push & PR trigger for the Integration-Checks workflow. Eventually, we'll be transitioning the repo over to using main and I wasn't initially sure if that would happen before or after the upcoming release, but now I'm sure it'll be in the new year.

@dcollins15 dcollins15 marked this pull request as ready for review December 20, 2024 13:09
@dcollins15 dcollins15 requested a review from rsatija December 20, 2024 13:10
@rharao
Copy link

rharao commented Dec 20, 2024

Are there plans for a linter?

@rharao
Copy link

rharao commented Dec 20, 2024

By the way, the Appveyor badge can be removed from the README

@dcollins15
Copy link
Contributor Author

Are there plans for a linter?

Linting is very high personal wish list but I'm hesitant to roll it out until we're able to get our test coverage up—with the current state of things, I'd be worried applying a tool like lintr could quietly introduce regressions into some of our messier code. We could probably start rolling out linting over time to be more conservative but I honestly haven't thought very much about how we'd go about it.

Is there a particular tool you'd recommend?


I thought the AppVeyor workflow would stop running after I removed the relevant webhook in the repository settings but it seems to still be getting triggered 😫 It seems like a common issue with an apparently simple solution but I'm running short on time for trouble shooting so I may just restore appveyor.yaml again and circle back to this later.

@dcollins15 dcollins15 changed the title Finalize CI Revamp Add master as trigger for Integration-Checks Dec 20, 2024
@dcollins15 dcollins15 merged commit eec805c into develop Dec 20, 2024
1 of 3 checks passed
@dcollins15 dcollins15 deleted the finalize-ci-revamp branch December 20, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants