Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/VisiumV1 return #9556

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Feat/VisiumV1 return #9556

merged 9 commits into from
Dec 20, 2024

Conversation

dcollins15
Copy link
Contributor

Adds an image.type parameter to Read10X_Image allowing users to choose which class is returned: VisiumV1 or VisiumV2. The behavior of the parameter is described in the following test script:

library(testthat)
library(Seurat)

path_to_image <- "path/to/image/"

visium_default <- Read10X_Image(path_to_image)
expect_true(inherits(visium_default, "VisiumV2"))

visium_v1 <- Read10X_Image(path_to_image, image.type = "VisiumV1")
expect_true(inherits(visium_v1, "VisiumV1"))

visium_v2 <- Read10X_Image(path_to_image, image.type = "VisiumV2")
expect_true(inherits(visium_v2, "VisiumV2"))

Relates to:

@dcollins15 dcollins15 changed the title Feat/visiumv1 return Feat/VisiumV1 return Dec 17, 2024
@dcollins15 dcollins15 requested a review from zskylarli December 17, 2024 19:50
@dcollins15 dcollins15 marked this pull request as ready for review December 20, 2024 05:34
@dcollins15 dcollins15 merged commit 6278779 into develop Dec 20, 2024
1 of 3 checks passed
@dcollins15 dcollins15 deleted the feat/visiumv1-return branch December 20, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant