Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Xenium): load renamed feature #6986

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

jsicherman
Copy link
Contributor

The feature type got changed from Blank Codeword to Unassigned Codeword, so this just loads from the new feature if the the old feature isn't found.

@AustinHartman AustinHartman changed the base branch from master to develop February 28, 2023 15:10
@AustinHartman AustinHartman merged commit 6a8a1cd into satijalab:develop Feb 28, 2023
@AustinHartman
Copy link
Contributor

Great, thanks for the update! I'll merge this into the develop branch and it will eventually make it into master as a part of the next CRAN release.

@Ceallaig33
Copy link

Ceallaig33 commented May 18, 2023

Hi @AustinHartman and @jsicherman - thanks for the fix on the develop branch. Looks like not updated on the seurat5 branch yet maybe? We ran into issue when trying LoadXenium() with xenium-1.3.0.6 output in seurat5 install. Thanks @aclark5 for pointing this out.

@jsicherman
Copy link
Contributor Author

Hi @Ceallaig33 - that's right, it looks like this has not yet merged to master or been in a CRAN release. Apologies for the inconvenience! devtools::install_github("satijalab/seurat@develop") should get you the fix from this branch in order to restore functionality on 1.3+ outputs until the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants