Fix heatmap legend; #4660

satijalab · Jul 16, 2021 · 93527b5 · 93527b5
1 parent 62a43ef
commit 93527b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -502,6 +502,7 @@ importFrom(ggplot2,position_jitterdodge)
 importFrom(ggplot2,scale_alpha)
 importFrom(ggplot2,scale_alpha_ordinal)
 importFrom(ggplot2,scale_color_brewer)
+importFrom(ggplot2,scale_color_discrete)
 importFrom(ggplot2,scale_color_distiller)
 importFrom(ggplot2,scale_color_gradient)
 importFrom(ggplot2,scale_color_gradientn)

diff --git a/R/visualization.R b/R/visualization.R
@@ -204,7 +204,7 @@ DimHeatmap <- function(
 #'
 #' @importFrom stats median
 #' @importFrom scales hue_pal
-#' @importFrom ggplot2 annotation_raster coord_cartesian scale_color_manual
+#' @importFrom ggplot2 annotation_raster coord_cartesian scale_color_discrete
 #' ggplot_build aes_string geom_text
 #' @importFrom patchwork wrap_plots
 #' @export
@@ -364,7 +364,7 @@ DoHeatmap <- function(
           ymax = y.max
         ) +
         coord_cartesian(ylim = c(0, y.max), clip = 'off') +
-        scale_color_manual(values = cols)
+        scale_color_discrete(name = "Identity", na.translate = FALSE)
       if (label) {
         x.max <- max(pbuild$layout$panel_params[[1]]$x.range)
         # Attempt to pull xdivs from x.major in ggplot2 < 3.3.0; if NULL, pull from the >= 3.3.0 slot