Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): add aria-hidden to chevron in language-switch #833

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

virus-rpi
Copy link
Collaborator

This pull request includes a small change to the src/components/layout/header/language-switch.tsx file to enhance accessibility by adding an ariaHidden attribute to the StyledChevron component.

@virus-rpi virus-rpi requested a review from a team as a code owner November 7, 2024 16:29
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 7e804d6
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/6734c0548d618a00083eabd9
😎 Deploy Preview https://deploy-preview-833--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi mentioned this pull request Nov 7, 2024
20 tasks
@virus-rpi virus-rpi changed the title fix (fix): add aria-hidden to chevron in language-switch fix (a11y): add aria-hidden to chevron in language-switch Nov 7, 2024
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I tested the fix with VoiceOver and it works great

@virus-rpi virus-rpi merged commit 8b77284 into main Nov 13, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/navigation/language-switch branch November 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants