Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global navigation close/open button #832

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

konclave
Copy link
Contributor

@konclave konclave commented Nov 7, 2024

The button was hidden by the block with menu on the short screens.
https://github.com/user-attachments/assets/2a24cd9c-255e-47a4-829e-0150bdc09494

The height of the button was quite small. I've increased it and made the active area a square.
SCR-20241107-jeba
SCR-20241107-jdyh

The button was hidden by the block with menu on the short screens. 
The height of the button was quite small. 
I've increased it and made the active area a square.
and remove positioning styles that should be applied by the container
@konclave konclave requested a review from a team as a code owner November 7, 2024 09:26
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 62d6af4
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/672c983fba65ef00084ee247
😎 Deploy Preview https://deploy-preview-832--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🚀 Thank you for recognizing and fixing this bug

@hofmann-felix hofmann-felix merged commit d2a13e3 into main Nov 13, 2024
6 checks passed
@hofmann-felix hofmann-felix deleted the fix/nav-button-improvement branch November 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants