Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change slack file upload method to uploadV2 #827

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

virus-rpi
Copy link
Collaborator

@virus-rpi virus-rpi commented Oct 17, 2024

Change:

  • use the new uploadV2 method instead of the upload method

https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay#prepare

@virus-rpi virus-rpi requested a review from a team as a code owner October 17, 2024 14:36
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 986775e
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/671120db514412000833ff64
😎 Deploy Preview https://deploy-preview-827--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for taking care of this

Can you please change these three things before the merge:

  1. Fix the typo in the PR description
  2. Assign yourself to the related issue
  3. Ensure that the commit message on main is lower case (fix: change slack file upload method to uploadV2). We should always try to be consistent with the other commits.

@virus-rpi virus-rpi self-assigned this Oct 17, 2024
@virus-rpi virus-rpi merged commit be68f3b into main Oct 17, 2024
6 checks passed
@virus-rpi virus-rpi deleted the fix/slack-file-upload branch October 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack API: files.upload retires in March 2025
2 participants