Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): make code block colors WCAG AA color contrast compliant #820

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

virus-rpi
Copy link
Collaborator

Changes:

Before:
image

After:
image

@virus-rpi virus-rpi requested a review from a team as a code owner September 18, 2024 15:44
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 0ddeda4
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/66ec39de3c436d00080141ee
😎 Deploy Preview https://deploy-preview-820--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi mentioned this pull request Sep 18, 2024
20 tasks
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎨 I tested the changes with https://accessibe.com/accessscan. It is happy about the colors in this branch but complains about the colors in main

@virus-rpi virus-rpi merged commit e6b777f into main Sep 19, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/blog/post/code branch September 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants