Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (a11y): breadcrumb a11y issues on blog page #805

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix (a11y): breadcrumb a11y issues on blog page #805

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc28342
fix: change breadcrumb text color from rgb(0, 0, 0, 0.5) to rgb(0, 0,…
Sep 2, 2024
5ac8d36
chore (a11y): use nav landmark instead of role navigation on the brea…
Sep 9, 2024
08c54d2
fix (a11y): breadcrumb focus outline now works without side effects
Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/layout/breadcrumb/breadcrumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const BreadcrumbContainer = styled.ol`
list-style: none;
display: flex;
flex-wrap: nowrap;
overflow: hidden;
virus-rpi marked this conversation as resolved.
Show resolved Hide resolved
padding: 0;
`;

Expand Down Expand Up @@ -45,7 +44,7 @@ export const Breadcrumb = ({
breadcrumbEntries,
}: BreadcrumbProps): JSX.Element => {
return (
<BreadcrumbContainer>
<BreadcrumbContainer aria-label="breadcumbs" role="navigation">
{breadcrumbEntries.map((breadcrumbEntry) => {
return (
<BreadcrumbListItem key={breadcrumbEntry.label}>
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout/theme.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const theme: DefaultTheme = {
light: '#3E61EE',
hover: '#202840',
},
breadcrumb: 'rgba(0, 0, 0, 0.5)',
breadcrumb: 'rgba(0, 0, 0, 0.65)',
link: {
default: '#3E61EE',
hover: '#4D79FF',
Expand Down