Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Problems found in automatic a11y testing #798

Merged

Conversation

virus-rpi
Copy link
Collaborator

@virus-rpi virus-rpi commented Feb 6, 2024

This PR fixes all problems found by the automatic a11y tests and this PR has to be merged so the test pass on the other branch.
This PR is very small because the other issues that were found by automated tests were fixed in the other a11y PRs

Changes:

  • Changed a li to a div because of the error "<li> elements must be contained in a <ul> or <ol> (listitem)"

@virus-rpi virus-rpi requested a review from a team as a code owner February 6, 2024 15:51
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 60d00da
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/66cc3c936cbdbb00083aa58e
😎 Deploy Preview https://deploy-preview-798--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi requested a review from maxmarkus February 12, 2024 16:09
@virus-rpi virus-rpi requested review from georgiee and removed request for maxmarkus February 19, 2024 17:17
Copy link
Member

@hofmann-felix hofmann-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀 Thanks for spotting and fixing this issue

@hofmann-felix hofmann-felix merged commit b576ce1 into main Aug 26, 2024
6 checks passed
@hofmann-felix hofmann-felix deleted the chore/a11y/fix-problems-found-by-automatic-testing branch August 26, 2024 08:49
@hofmann-felix hofmann-felix mentioned this pull request Aug 26, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants