Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility problems without category #794

Merged
merged 9 commits into from
Feb 6, 2024
Merged

Conversation

virus-rpi
Copy link
Collaborator

Changes

  • Add aria-label to "Satalytes" button in header ("Link to Satellytes homepage")
  • Increased font size in "Did you get interested?" section on service page:
    Before:
image

After:
image

  • Add aria-hidden to invisible links on the imprint page
  • Made the "Learn more >" button text on landing page more clear: "More about our services >" (German: "Erfahren Sie mehr" -> "Mehr details zu unseren Leistungen")

@virus-rpi virus-rpi requested a review from a team as a code owner January 15, 2024 14:09
Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 6edc001
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/65c24a37fee9f60008737f2d
😎 Deploy Preview https://deploy-preview-794--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (🟢 up 7 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo. The other changes look sane 👍

src/assets/locales/de/translations.json Outdated Show resolved Hide resolved
@virus-rpi virus-rpi requested a review from maxmarkus February 5, 2024 15:53
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@virus-rpi virus-rpi merged commit 00f8324 into main Feb 6, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/fix-misc branch February 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants